More robust

This commit is contained in:
2025-10-05 16:03:51 +02:00
parent 2f8f75dfa1
commit 211d4442e5
5 changed files with 186 additions and 38 deletions

View File

@@ -1,13 +1,32 @@
#!/bin/bash
set -euo pipefail
# Function to run commands with sudo only if not root
run_as_root() {
if [[ $EUID -eq 0 ]]; then
"$@"
else
sudo "$@"
fi
}
CONFIG_FILE=/etc/hdd_temp_monitor.conf
SERVICE_FILE=/etc/systemd/system/hotdisk.service
TIMER_FILE=/etc/systemd/system/hotdisk.timer
echo "=== HotDisk Installation ==="
DEPENDENCIES=(bash smartctl curl lsblk awk date tee sudo systemctl)
DEPENDENCIES=(bash smartctl curl lsblk awk date tee systemctl)
MISSING=()
# Check dependencies - skip sudo if running as root
for cmd in "${DEPENDENCIES[@]}"; do
if ! command -v "$cmd" >/dev/null 2>&1; then MISSING+=("$cmd"); fi
done
# Only check for sudo if not running as root
if [[ $EUID -ne 0 ]] && ! command -v sudo >/dev/null 2>&1; then
MISSING+=("sudo")
fi
if [ ${#MISSING[@]} -ne 0 ]; then
echo "❌ Missing dependencies:"
for cmd in "${MISSING[@]}"; do echo " - $cmd"; done
@@ -17,49 +36,81 @@ fi
echo "✅ All dependencies are installed."
read -p "Maximum temperature (°C) before shutdown [60]: " MAX_TEMP
MAX_TEMP=${MAX_TEMP:-60}
if ! [[ "$MAX_TEMP" =~ ^[0-9]+$ ]] || [[ $MAX_TEMP -lt 1 || $MAX_TEMP -gt 100 ]]; then
echo "ERROR: MAX_TEMP must be a number between 1-100" >&2
exit 1
fi
read -p "Consecutive minutes above MAX_TEMP before shutdown [5]: " HOT_DURATION
HOT_DURATION=${HOT_DURATION:-5}
read -p "Consecutive minutes below MAX_TEMP to reset counter [5]: " COOL_DURATION
COOL_DURATION=${COOL_DURATION:-5}
if ! [[ "$HOT_DURATION" =~ ^[0-9]+$ ]] || [[ $HOT_DURATION -lt 1 ]]; then
echo "ERROR: HOT_DURATION must be a positive number" >&2
exit 1
fi
read -p "Minutes below MAX_TEMP to reset all counters [5]: " COOL_RESET_DURATION
COOL_RESET_DURATION=${COOL_RESET_DURATION:-5}
if ! [[ "$COOL_RESET_DURATION" =~ ^[0-9]+$ ]] || [[ $COOL_RESET_DURATION -lt 1 ]]; then
echo "ERROR: COOL_RESET_DURATION must be a positive number" >&2
exit 1
fi
read -p "Log file path [/var/log/hdd_temp_monitor.log]: " LOG_FILE
LOG_FILE=${LOG_FILE:-/var/log/hdd_temp_monitor.log}
read -p "Logrotate: number of files to keep [7]: " LOG_ROTATE_COUNT
LOG_ROTATE_COUNT=${LOG_ROTATE_COUNT:-7}
if ! [[ "$LOG_ROTATE_COUNT" =~ ^[0-9]+$ ]] || [[ $LOG_ROTATE_COUNT -lt 1 ]]; then
echo "ERROR: LOG_ROTATE_COUNT must be a positive number" >&2
exit 1
fi
read -p "Logrotate: rotation period (daily/weekly) [daily]: " LOG_ROTATE_PERIOD
LOG_ROTATE_PERIOD=${LOG_ROTATE_PERIOD:-daily}
if [[ ! "$LOG_ROTATE_PERIOD" =~ ^(daily|weekly)$ ]]; then
echo "ERROR: LOG_ROTATE_PERIOD must be 'daily' or 'weekly'" >&2
exit 1
fi
echo "Paste your Discord Webhook URL here."
read -p "Discord Webhook URL: " DISCORD_WEBHOOK
[ -z "$DISCORD_WEBHOOK" ] && { echo "Discord Webhook cannot be empty"; exit 1; }
if [[ -z "$DISCORD_WEBHOOK" ]]; then
echo "ERROR: Discord Webhook cannot be empty" >&2
exit 1
fi
# Validate Discord webhook URL format
if [[ ! "$DISCORD_WEBHOOK" =~ ^https://discord(app)?\.com/api/webhooks/ ]]; then
echo "ERROR: Invalid Discord webhook URL format" >&2
exit 1
fi
echo ""
echo "Please confirm:"
echo "MAX_TEMP=$MAX_TEMP"
echo "HOT_DURATION=$HOT_DURATION"
echo "COOL_DURATION=$COOL_DURATION"
echo "COOL_RESET_DURATION=$COOL_RESET_DURATION"
echo "LOG_FILE=$LOG_FILE"
echo "LOG_ROTATE_COUNT=$LOG_ROTATE_COUNT"
echo "LOG_ROTATE_PERIOD=$LOG_ROTATE_PERIOD"
echo "DISCORD_WEBHOOK=$DISCORD_WEBHOOK"
read -p "Is this correct? (y/n): " CONFIRM
[[ ! "$CONFIRM" =~ ^[Yy]$ ]] && { echo "Aborted"; exit 1; }
sudo tee "$CONFIG_FILE" > /dev/null <<EOF
run_as_root tee "$CONFIG_FILE" > /dev/null <<EOF
MAX_TEMP=$MAX_TEMP
HOT_DURATION=$HOT_DURATION
COOL_DURATION=$COOL_DURATION
COOL_RESET_DURATION=$COOL_RESET_DURATION
LOG_FILE=$LOG_FILE
LOG_ROTATE_COUNT=$LOG_ROTATE_COUNT
LOG_ROTATE_PERIOD=$LOG_ROTATE_PERIOD
DISCORD_WEBHOOK=$DISCORD_WEBHOOK
EOF
sudo chmod +x /usr/local/bin/sh/hotdisk.sh /usr/local/bin/sh/hotdisk_logger.sh
sudo /usr/local/bin/sh/hotdisk_logger.sh
sudo tee "$SERVICE_FILE" > /dev/null <<EOF
run_as_root chmod +x /usr/local/bin/hotdisk.sh /usr/local/bin/hotdisk_logger.sh
run_as_root /usr/local/bin/hotdisk_logger.sh
run_as_root tee "$SERVICE_FILE" > /dev/null <<EOF
[Unit]
Description=HotDisk SATA Temperature Check
[Service]
Type=oneshot
ExecStart=/usr/local/bin/sh/hotdisk.sh
ExecStart=/usr/local/bin/hotdisk.sh
EOF
sudo tee "$TIMER_FILE" > /dev/null <<EOF
run_as_root tee "$TIMER_FILE" > /dev/null <<EOF
[Unit]
Description=Run HotDisk temperature check every minute
[Timer]
@@ -69,7 +120,7 @@ Persistent=true
[Install]
WantedBy=timers.target
EOF
sudo systemctl daemon-reload
sudo systemctl enable --now hotdisk.timer
sudo /usr/local/bin/sh/hotdisk.sh
run_as_root systemctl daemon-reload
run_as_root systemctl enable --now hotdisk.timer
run_as_root /usr/local/bin/hotdisk.sh
echo "✅ HotDisk installation complete!"