Merge pull request 'New release template' (#30) from dev-ci into main

Reviewed-on: #30

.gitea/workflows/ci.yml

@@ -5,6 +5,8 @@ on:
     branches: [main]
   pull_request:
     branches: [main]
+  schedule:
+    - cron: "0 6 * * 1"
 
 jobs:
   build-and-scan:
@@ -16,126 +18,172 @@ jobs:
           fetch-depth: 0
           persist-credentials: false
 
-      - name: Build prod image
+      - name: Build Docker image
-        run: docker build -t lumeex:ci .
+        run: |
+          docker build -t lumeex:ci . 2>&1 | tee build.log
+          if grep -q "Building wheel for" build.log; then
+            echo "::warning::A dependency was built from source — check Python/Alpine compatibility"
+          fi
 
-      - name: Smoke test
+      - name: Smoke test (syntax check)
         run: |
           docker run --rm --entrypoint python lumeex:ci -c "
           import ast
-          ast.parse(open('build.py').read())
+          ok = True
-          ast.parse(open('gallery.py').read())
+          for f in ('build.py', 'gallery.py'):
-          print('syntax ok')
+              with open(f) as fh:
+                  source = fh.read()
+              try:
+                  ast.parse(source)
+              except SyntaxError as e:
+                  print(f'::error::Syntax error in {f}: {e}')
+                  ok = False
+          if not ok:
+              exit(1)
+          print('OK: syntax is valid')
           "
 
-      - name: Build test image
+      - name: Run unit tests
-        run: docker build --target test -t lumeex:test .
+        run: |
-
+          docker build --target test -t lumeex:test .
-      - name: Unit tests
+          docker run --rm lumeex:test pytest -v
-        run: docker run --rm lumeex:test pytest -v
 
       - name: Check deprecation warnings
-        run: docker run --rm --entrypoint python lumeex:ci -W error::DeprecationWarning -c "import src.py.webui.webui"
+        run: |
+          docker run --rm --entrypoint python lumeex:ci -W error::DeprecationWarning -c "import src.py.webui.webui" 2>&1 | tee deprecation.log || true
+          if grep -qi "deprecat" deprecation.log; then
+            echo "::warning::Deprecation warning detected, check logs"
+          fi
 
-      - name: Trivy critical (blocking)
+      - name: Scan with Trivy (critical - blocking)
         run: |
           docker run --rm \
-            -e DOCKER_HOST=tcp://dockerhost:2375 --add-host=dockerhost:host-gateway \
+            -e DOCKER_HOST=tcp://dockerhost:2375 \
-            -v /var/run/docker.sock:/var/run/docker.sock \
+            --add-host=dockerhost:host-gateway \
-            aquasec/trivy image --exit-code 1 --severity CRITICAL lumeex:ci
+            aquasec/trivy:0.74.0 image --exit-code 1 --severity CRITICAL lumeex:ci
 
-      - name: Trivy high (informative)
+      - name: Scan with Trivy (high - informative)
         run: |
           docker run --rm \
-            -e DOCKER_HOST=tcp://dockerhost:2375 --add-host=dockerhost:host-gateway \
+            -e DOCKER_HOST=tcp://dockerhost:2375 \
-            -v /var/run/docker.sock:/var/run/docker.sock \
+            --add-host=dockerhost:host-gateway \
-            aquasec/trivy image --exit-code 0 --severity HIGH lumeex:ci
+            aquasec/trivy:0.74.0 image --exit-code 0 --severity HIGH lumeex:ci
 
       - name: Publish tagged image
         if: github.event_name == 'push' && github.ref == 'refs/heads/main'
-        env:
-          REGISTRY_TOKEN: ${{ secrets.REGISTRY_TOKEN }}
-          CI_PUSH_TOKEN: ${{ secrets.CI_PUSH_TOKEN }}
-          GITEA_URL: https://git.djeex.fr
-          IMAGE: git.djeex.fr/djeex/lumeex
         run: |
-          set -e
-
-          # Only republish when a container-relevant file actually changed
           BEFORE="${{ github.event.before }}"
-          if [ -z "$BEFORE" ] || [ "$BEFORE" = "0000000000000000000000000000000000000000" ]; then
+          if [ -n "$BEFORE" ] && [ "$BEFORE" != "0000000000000000000000000000000000000000" ] && git cat-file -e "$BEFORE" 2>/dev/null; then
-            BEFORE="HEAD~1"
+            BASE_REF="$BEFORE"
+          else
+            BASE_REF="HEAD~1"
           fi
-          CHANGED=$(git diff --name-only "$BEFORE" "${{ github.sha }}" -- \
+          CHANGED=$(git diff --name-only "$BASE_REF" "${{ github.sha }}")
-            Dockerfile requirements.txt VERSION build.py gallery.py \
+          echo "Changed files:"
-            src/ config/ docker/.sh/entrypoint.sh || true)
+          echo "$CHANGED"
 
-          if [ -z "$CHANGED" ]; then
+          if ! echo "$CHANGED" | grep -qE '^(Dockerfile|requirements\.txt|VERSION|build\.py|gallery\.py)$|^(src|config)/|^docker/\.sh/entrypoint\.sh$'; then
-            echo "No container-relevant changes, skipping publish."
+            echo "No container-relevant file changed, skipping publish."
             exit 0
           fi
 
-          VERSION_BUMPED=false
+          if echo "$CHANGED" | grep -qE '^VERSION$'; then
-          if ! echo "$CHANGED" | grep -qx "VERSION"; then
+            echo "VERSION was manually edited in this push, using it as-is."
-            CURRENT_VERSION=$(cat VERSION)
+          else
-            MAJOR=$(echo "$CURRENT_VERSION" | cut -d. -f1)
+            echo "VERSION untouched but container files changed, auto-bumping the build number (Z)."
-            MINOR=$(echo "$CURRENT_VERSION" | cut -d. -f2)
+            OLD_VERSION=$(tr -d '[:space:]' < VERSION)
-            PATCH=$(echo "$CURRENT_VERSION" | cut -d. -f3)
+            IFS='.' read -r MAJOR MINOR PATCH <<< "$OLD_VERSION"
-            NEW_VERSION="$MAJOR.$MINOR.$((PATCH + 1))"
+            NEW_VERSION="${MAJOR}.${MINOR}.$((PATCH + 1))"
             echo "$NEW_VERSION" > VERSION
 
-            git config user.name "gitea-ci"
+            git config user.name "lumeex-ci"
             git config user.email "[email protected]"
-            git remote set-url origin "https://gitea-ci:${CI_PUSH_TOKEN}@git.djeex.fr/Djeex/lumeex.git"
             git add VERSION
-            git commit -m "chore: bump version to $NEW_VERSION [skip ci]"
+            git commit -m "Bump build version to $NEW_VERSION [skip ci]"
-            git push origin HEAD:main
+
-            git config --unset-all "http.https://git.djeex.fr/Djeex/lumeex.git/.extraheader" || true
+            # Belt and suspenders: actions/checkout can leave its own ephemeral
-            VERSION_BUMPED=true
+            # credential injected as an extraheader, which would silently override
+            # the URL-embedded token below. persist-credentials:false on checkout
+            # should already prevent this, but strip it here too just in case.
+            git config --unset-all http.https://git.djeex.fr/.extraheader || true
+
+            git push "https://Djeex:${{ secrets.CI_PUSH_TOKEN }}@git.djeex.fr/Djeex/lumeex.git" HEAD:main
           fi
 
-          FULL_VERSION=$(cat VERSION)
+          VERSION=$(tr -d '[:space:]' < VERSION)
-          MAJOR_MINOR=$(echo "$FULL_VERSION" | cut -d. -f1,2)
+          IFS='.' read -r MAJOR MINOR PATCH <<< "$VERSION"
+          MINOR_TAG="${MAJOR}.${MINOR}"
 
-          echo "$REGISTRY_TOKEN" | docker login git.djeex.fr -u Djeex --password-stdin
+          IMAGE=git.djeex.fr/djeex/lumeex
+          echo "${{ secrets.REGISTRY_TOKEN }}" | docker login git.djeex.fr -u Djeex --password-stdin
 
+          # Retag the already-built, already-scanned image — never rebuild for publish,
+          # so what ships is byte-for-byte what Trivy just scanned.
           docker tag lumeex:ci "$IMAGE:latest"
-          docker tag lumeex:ci "$IMAGE:$MAJOR_MINOR"
+          docker tag lumeex:ci "$IMAGE:$MINOR_TAG"
-          docker tag lumeex:ci "$IMAGE:$FULL_VERSION"
+          docker tag lumeex:ci "$IMAGE:$VERSION"
           docker push "$IMAGE:latest"
-          docker push "$IMAGE:$MAJOR_MINOR"
+          docker push "$IMAGE:$MINOR_TAG"
-          docker push "$IMAGE:$FULL_VERSION"
+          docker push "$IMAGE:$VERSION"
+
+          TRIGGER_MSG=$(git log -1 --format=%s "${{ github.sha }}")
+          PR_NUM=$(echo "$TRIGGER_MSG" | grep -oE '#[0-9]+' | head -1 | tr -d '#' || true)
 
-          # Categorize the changelog from the merged PR's labels, if any
-          PR_NUMBER=$(git log -1 --format=%B "${{ github.sha }}" | grep -oE '#[0-9]+' | head -1 | tr -d '#' || true)
           CATEGORY="🔧 Maintenance"
-          PR_LINK=""
+          CHANGE_TITLE="$TRIGGER_MSG"
-          if [ -n "$PR_NUMBER" ]; then
+
-            PR_LINK="https://git.djeex.fr/Djeex/lumeex/pulls/$PR_NUMBER"
+          if [ -n "$PR_NUM" ]; then
-            LABELS=$(curl -s -H "Authorization: token $CI_PUSH_TOKEN" \
+            PR_JSON=$(curl -s -H "Authorization: token ${{ secrets.CI_PUSH_TOKEN }}" \
-              "$GITEA_URL/api/v1/repos/Djeex/lumeex/issues/$PR_NUMBER/labels" | jq -r '.[].name' || true)
+              "https://git.djeex.fr/api/v1/repos/Djeex/lumeex/pulls/$PR_NUM")
-            if echo "$LABELS" | grep -qx "bug"; then
+            PR_TITLE=$(echo "$PR_JSON" | jq -r '.title // empty' 2>/dev/null || true)
+            LABELS=$(echo "$PR_JSON" | jq -r '.labels[]?.name' 2>/dev/null || true)
+
+            if [ -n "$PR_TITLE" ]; then
+              CHANGE_TITLE="$PR_TITLE"
+            fi
+
+            if echo "$LABELS" | grep -qx 'bug'; then
               CATEGORY="⚠️ Hotfix"
-            elif echo "$LABELS" | grep -qx "major"; then
+            elif echo "$LABELS" | grep -qx 'major'; then
               CATEGORY="💥 Breaking change"
-            elif echo "$LABELS" | grep -qx "minor"; then
+            elif echo "$LABELS" | grep -qx 'minor'; then
               CATEGORY="✨ Update"
             fi
           fi
 
-          COMMIT_LINK="https://git.djeex.fr/Djeex/lumeex/commit/${{ github.sha }}"
+          REPO_URL="https://git.djeex.fr/Djeex/lumeex"
-          BODY=$(printf '**%s**\n\nCommit: %s' "$CATEGORY" "$COMMIT_LINK")
+          COMMIT_LIST=$(git log --no-merges --format="- [%h](${REPO_URL}/commit/%H) %s" "$BASE_REF".."${{ github.sha }}")
-          if [ -n "$PR_LINK" ]; then
+
-            BODY=$(printf '%s\nPR: %s' "$BODY" "$PR_LINK")
+          SHORT_SHA=$(echo "${{ github.sha }}" | cut -c1-7)
+          SOURCE_LINE="[${SHORT_SHA}](${REPO_URL}/commit/${{ github.sha }})"
+          if [ -n "$PR_NUM" ]; then
+            SOURCE_LINE="[#${PR_NUM}](${REPO_URL}/pulls/${PR_NUM}) · ${SOURCE_LINE}"
           fi
 
-          jq -n \
+          BODY=$(cat <<EOF
-            --arg tag "$FULL_VERSION" \
+          ## Changelog
-            --arg name "$FULL_VERSION" \
+          ---
+
+          ### ${CATEGORY}
+          ---
+          ${CHANGE_TITLE}
+
+          **Source:** ${SOURCE_LINE}
+          **Image:** \`${IMAGE}:${VERSION}\`
+
+          **Commits:**
+          ${COMMIT_LIST}
+          EOF
+          )
+
+          JSON_PAYLOAD=$(jq -n \
+            --arg tag "$VERSION" \
+            --arg name "$VERSION" \
             --arg body "$BODY" \
-            '{tag_name: $tag, name: $name, body: $body}' | \
+            '{tag_name: $tag, name: $name, target_commitish: "main", body: $body}')
-          curl -s -X POST \
+
-            -H "Authorization: token $CI_PUSH_TOKEN" \
+          curl -s -o /dev/null -w "Release API response: %{http_code}\n" -X POST \
+            -H "Authorization: token ${{ secrets.CI_PUSH_TOKEN }}" \
             -H "Content-Type: application/json" \
-            -d @- \
+            -d "$JSON_PAYLOAD" \
-            "$GITEA_URL/api/v1/repos/Djeex/lumeex/releases"
+            "https://git.djeex.fr/api/v1/repos/Djeex/lumeex/releases"