Add Telegram notifications, make Discord optional

This commit is contained in:
2026-10-28 17:47:36 +01:00
parent b61feb4fef
commit 775dd4178d
9 changed files with 313 additions and 19 deletions
+24 -3
View File
@@ -11,6 +11,8 @@ ENV_KEYS = [
"DISCORD_WEBHOOK_URL",
"DISCORD_SERVER_NAME",
"DISCORD_ROLES",
"TELEGRAM_BOT_TOKEN",
"TELEGRAM_CHAT_ID",
"COUNTRY",
"REFRESH_TIME",
"TEST_MODE",
@@ -27,9 +29,28 @@ def _reload_env_config(monkeypatch, env):
return importlib.import_module(MODULE_NAME)
def test_missing_webhook_exits(monkeypatch):
with pytest.raises(SystemExit):
_reload_env_config(monkeypatch, {"PRODUCT_NAMES": "RTX 5090"})
def test_no_notification_channel_does_not_exit(monkeypatch, caplog):
cfg = _reload_env_config(monkeypatch, {"PRODUCT_NAMES": "RTX 5090"})
assert not cfg.DISCORD_ENABLED
assert not cfg.TELEGRAM_ENABLED
assert "DISCORD IS NOT CONFIGURED" in caplog.text
assert "TELEGRAM IS NOT CONFIGURED" in caplog.text
def test_telegram_only_is_enabled(monkeypatch):
cfg = _reload_env_config(
monkeypatch,
{"PRODUCT_NAMES": "RTX 5090", "TELEGRAM_BOT_TOKEN": "123:abc", "TELEGRAM_CHAT_ID": "-100"},
)
assert cfg.TELEGRAM_ENABLED
assert not cfg.DISCORD_ENABLED
def test_telegram_partial_config_is_disabled(monkeypatch):
cfg = _reload_env_config(
monkeypatch, {"PRODUCT_NAMES": "RTX 5090", "TELEGRAM_BOT_TOKEN": "123:abc"}
)
assert not cfg.TELEGRAM_ENABLED
def test_missing_product_names_exits(monkeypatch):
+76 -2
View File
@@ -4,10 +4,13 @@ import sys
VALID_WEBHOOK = "https://discord.com/api/webhooks/123456789012345678/abcdef"
def _import_notifier(monkeypatch, test_mode="False", discord_roles=None):
monkeypatch.setenv("DISCORD_WEBHOOK_URL", VALID_WEBHOOK)
def _import_notifier(monkeypatch, test_mode="False", discord_roles=None, keep_discord=True):
if keep_discord:
monkeypatch.setenv("DISCORD_WEBHOOK_URL", VALID_WEBHOOK)
monkeypatch.setenv("PRODUCT_NAMES", "RTX 5090 Founders Edition")
monkeypatch.setenv("TEST_MODE", test_mode)
if not keep_discord:
monkeypatch.delenv("DISCORD_WEBHOOK_URL", raising=False)
if discord_roles is not None:
monkeypatch.setenv("DISCORD_ROLES", discord_roles)
else:
@@ -185,3 +188,74 @@ def test_sku_change_notification_mentions_role_and_skus(monkeypatch):
description = captured["json"]["embeds"][0]["description"]
assert "old-sku-123" in description
assert "new-sku-456" in description
def _import_telegram_notifier(monkeypatch, with_discord=False):
if not with_discord:
monkeypatch.delenv("DISCORD_WEBHOOK_URL", raising=False)
monkeypatch.setenv("TELEGRAM_BOT_TOKEN", "123:abc")
monkeypatch.setenv("TELEGRAM_CHAT_ID", "-100123")
return _import_notifier(monkeypatch, test_mode="False", keep_discord=with_discord)
def test_telegram_in_stock_posts_to_bot_api(monkeypatch):
notifier = _import_telegram_notifier(monkeypatch)
captured = {}
def fake_post(url, json=None, **kwargs):
captured["url"] = url
captured["json"] = json
return FakeResponse(status_code=200)
monkeypatch.setattr(notifier.requests, "post", fake_post)
notifier.send_telegram_notification("RTX 5090 Founders Edition", "https://example.com/buy", "1999")
assert captured["url"] == "https://api.telegram.org/bot123:abc/sendMessage"
assert captured["json"]["chat_id"] == "-100123"
assert "RTX 5090 Founders Edition" in captured["json"]["text"]
assert "https://example.com/buy" in captured["json"]["text"]
def test_telegram_disabled_sends_nothing(monkeypatch):
notifier = _import_notifier(monkeypatch, test_mode="False")
calls = []
monkeypatch.setattr(notifier.requests, "post", lambda *a, **k: calls.append(a))
notifier.send_telegram_notification("RTX 5090 Founders Edition", "https://example.com", "1999")
notifier.send_telegram_out_of_stock_notification("RTX 5090", "https://example.com", "1999")
notifier.send_telegram_sku_change_notification("RTX 5090", "a", "b", "https://example.com")
assert calls == []
def test_discord_disabled_sends_nothing(monkeypatch):
notifier = _import_telegram_notifier(monkeypatch)
calls = []
monkeypatch.setattr(notifier.requests, "post", lambda *a, **k: calls.append(a))
notifier.send_discord_notification("RTX 5090 Founders Edition", "https://example.com", "1999")
assert calls == []
def test_telegram_error_does_not_leak_token_or_raise(monkeypatch, caplog):
notifier = _import_telegram_notifier(monkeypatch)
def raise_error(*a, **k):
raise notifier.requests.exceptions.ConnectionError("https://api.telegram.org/bot123:abc/")
monkeypatch.setattr(notifier.requests, "post", raise_error)
notifier.send_telegram_out_of_stock_notification("RTX 5090", "https://example.com", "1999")
assert "123:abc" not in caplog.text
def test_telegram_sku_change_and_http_error(monkeypatch):
notifier = _import_telegram_notifier(monkeypatch)
monkeypatch.setattr(
notifier.requests, "post", lambda *a, **k: FakeResponse(status_code=400, text="bad")
)
notifier.send_telegram_sku_change_notification("RTX 5090", "old", "new", "https://example.com")